Core: Fix empty rule comparisons with subclasses #4201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
If a world uses a
Location
orEntrance
subclass that overrides theitem_rule
/access_rule
class attribute, thenspot.__class__.item_rule
/spot.__class__.access_rule
will get the overridden rule, which may not be an empty rule.Uses of
spot.__class__
have been replaced with getting the class attribute rule belonging to theLocation
orEntrance
class.How was this tested?