Aquaria: Fixing no progression bug #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
approved these changes
Nov 17, 2024
Exempt-Medic
added
the
is: bug/fix
Can you send me the yaml that failed please @Exempt-Medic ? |
Sent them in DM's on Discord |
tioui
added
waiting-on: world-maintainer
Exempt-Medic
added
waiting-on: peer-review
Berserker66
reviewed
Nov 17, 2024
| @@ -1152,79 +1152,79 @@ def __adjusting_manual_rules(self) -> None: | |||
| def __no_progression_hard_or_hidden_location(self) -> None: | |||
| self.multiworld.get_location("Energy Temple boss area, Fallen God Tooth", | |||
| self.player).item_rule = \ | |||
| lambda item: item.classification != ItemClassification.progression | |||
| lambda item: not item.advancement | |||
There was a problem hiding this comment.
For future reference, each lambda lives in memory, so it would be more efficient to define this once and paste it across all relevant locations.
There was a problem hiding this comment.
Do you mean that lambdas are never collected? Like for the rest of the execution of the program?
Berserker66
approved these changes
Nov 17, 2024
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The
no_progression_hard_or_hidden_locationsoption had the problem to not excludingprogression_skip_balancingitem. Now, this option remove every item that are advancement item.How was this tested?
I launched the unit test and generate 100 completely random single player game. All passed without error.