-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: fix deprecation warning in for utcnow() #4170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Issues/PRs that touch core and may need additional validation.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
labels
Nov 11, 2024
9 tasks
silasary
approved these changes
Nov 15, 2024
ScipioWright
added
the
waiting-on: other
Issue/PR is waiting for something else, like another PR.
label
Nov 19, 2024
nicholassaylor
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this should work now that 3.8 is binned
nicholassaylor
suggested changes
Nov 28, 2024
Co-authored-by: Nicholas Saylor <[email protected]>
Co-authored-by: Nicholas Saylor <[email protected]>
black-sliver
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> from datetime import datetime, timezone
>>> datetime.utcnow().hour == datetime.now(timezone.utc).hour
True
nicholassaylor
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects: core
Issues/PRs that touch core and may need additional validation.
waiting-on: other
Issue/PR is waiting for something else, like another PR.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). self.buildtime = datetime.datetime.utcnow()
How was this tested?
running setup.py build_exe on py 3.12
If this makes graphical changes, please attach screenshots.