Core: downgrade websockets and minor fixes #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14.x currently doesn't work for MultiServer. 14.x is not supported with py3.8, so updating to 14.x should be scheduled for AP 0.6.0.
black-sliver
added
is: bug/fix
github-actions
bot
added
the
waiting-on: peer-review
this is 4x expected time, just to be safe.
qwint
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
was able to recreate the 'ServerConnection' object has no attribute 'open' error Black Sliver posted in the discord on websockets 14 and was properly downgraded (and did not error) on this branch
rest of the changes look reasonable but didn't explicitly test them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
How was this tested?
CI