LTTP: Update to options API #4134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: refactor/cleanup
github-actions
bot
added
the
affects: core
|
Looks like this will be necessary to get in sooner rather than later. Alright, will have a look at this soon. |
nicholassaylor
changed the title
|
I believe that this PR is now in a state to properly review. The world -> multiworld changes have been moved to a branch that will be PRed after this gets looked at. PR post now accurately reflects the state of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
per_slot_randomswere elimated in the codeIn various spots, instances of(Will be moved to another PR)world: Multiworld, explicit or implied were eliminatedThis would "supercede" #3764 and #3763
Also would solve concerns in #3382 and #3284
How was this tested?
Running all unittests
Running Generate with seed=1 and comparing patch files and spoiler logs