Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KH2] Add new Poptracker Pack to the KH2 Setup Guide #4104

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

palex00
Copy link
Contributor

@palex00 palex00 commented Oct 26, 2024

What is this fixing or adding?

Adding the new Poptracker Pack developed by @Ugh-Sunlight and me. Both have full access to the repository and can continue the work if the other dies.

The pack is based on the logic sheet and is still being tested thoroughly but it already extremly accurate. The maintainer of KH2 is aware of the pack and it is pinned in the channel.

The pack is currently not yet fully done (1.0.0) because some Icons are still placeholder but before 0.5.1 drops that will be done.

How was this tested?

Visual look at the Setup Guide. Pack itself is being tested here

If this makes graphical changes, please attach screenshots.

image
image-1

@github-actions github-actions bot added the is: documentation Improvements or additions to documentation. label Oct 26, 2024
@palex00
Copy link
Contributor Author

palex00 commented Oct 26, 2024

@JaredWeakStrike

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Oct 26, 2024
@Exempt-Medic Exempt-Medic added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Oct 26, 2024
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through and everything looks good now

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, displays and reads well and matches the formatting in the rest of the file

@Exempt-Medic Exempt-Medic removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Oct 27, 2024
@JaredWeakStrike
Copy link
Collaborator

lgtm

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Oct 27, 2024
@NewSoupVi NewSoupVi merged commit 9b5a2be into ArchipelagoMW:main Oct 28, 2024
12 checks passed
@palex00 palex00 deleted the patch-25 branch December 1, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants