-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KH2] Add new Poptracker Pack to the KH2 Setup Guide #4104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
is: documentation
Improvements or additions to documentation.
label
Oct 26, 2024
github-actions
bot
added
the
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
label
Oct 26, 2024
Exempt-Medic
added
the
waiting-on: world-maintainer
Issue/PR is waiting for feedback or approval by the maintainer of a world.
label
Oct 26, 2024
Co-authored-by: Exempt-Medic <[email protected]>
nicholassaylor
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through and everything looks good now
Exempt-Medic
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, displays and reads well and matches the formatting in the rest of the file
Exempt-Medic
removed
the
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
label
Oct 27, 2024
lgtm |
Exempt-Medic
added
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
and removed
waiting-on: world-maintainer
Issue/PR is waiting for feedback or approval by the maintainer of a world.
labels
Oct 27, 2024
NewSoupVi
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
is: documentation
Improvements or additions to documentation.
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adding the new Poptracker Pack developed by @Ugh-Sunlight and me. Both have full access to the repository and can continue the work if the other dies.
The pack is based on the logic sheet and is still being tested thoroughly but it already extremly accurate. The maintainer of KH2 is aware of the pack and it is pinned in the channel.
The pack is currently not yet fully done (1.0.0) because some Icons are still placeholder but before 0.5.1 drops that will be done.
How was this tested?
Visual look at the Setup Guide. Pack itself is being tested here
If this makes graphical changes, please attach screenshots.