-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stardew Valley: Remove some events for a slight performance increase #4085
Stardew Valley: Remove some events for a slight performance increase #4085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, the rules apply properly and all instances of the events are converted over. Did some test generations and the indirect connections are properly formed as well.
Found a bug while running tests in another branch, while working on something else. It appears that entrances in the arcade machines, the mines, the skull caverns, and most importantly, the regions for tool upgrade were not using the Tool upgrade require money, which need access to Pierre's. When Pierre's was entrance rando-ed somewhere with logic, the indirect connection was not properly registered. |
…rchipelagoMW#4085) (cherry picked from commit ed4e44b)
What is this fixing or adding?
This PR removes some events that were added to handle indirect connection between the Carpenter shop, Pierre and some buildings (only relevant when building progression is vanilla with entrance randomizer). Since the 5.x.x update, indirect connection are automatically calculated and registered every time a rule is added to an entrance, so those events are unnecessary.
This improves performances for two reasons:
How was this tested?
If this makes graphical changes, please attach screenshots.
N/A