WebHost: Fix NamedRange dropdown being blank instead of Custom for presets #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when applying presets
github-actions
bot
added
affects: webhost
remyjette
added
the
is: bug/fix
qwint
approved these changes
Oct 16, 2024
agilbert1412
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
For some reason, this almost-one-liner feels suboptimal to me. Like my instinct is telling me there is probably a cleaner way to do it.
But I've been trying to come up with one, and have been unsuccessful. So in the absence of an alternative, I think this is good enough!
remyjette
added
waiting-on: core-review
Berserker66
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
@agilbert1412 wrote up a very good description of the bug in https://discord.com/channels/731205301247803413/1295518127974776885.
This issue is caused because when applying presets, after we determine the true value of the NamedRange from the preset, we try to set the
namedRangeSelectto that value. If the value doesn't exist, trying to do so unsets theselectelement. This change detects if it was flipped to unselected (.selectedIndex == -1) and changes it to"custom"instead.How was this tested?
Ran the WebHost locally, loaded up the Stardew Valley player option page, applied the available presets.