Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebHost: delete unused script tag #4062

Merged
merged 1 commit into from
Nov 29, 2024
Merged

WebHost: delete unused script tag #4062

merged 1 commit into from
Nov 29, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Removes a script that as far as I can tell, is unused on this page.

How was this tested?

locally

@github-actions github-actions bot added affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 16, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Oct 19, 2024
nicholassaylor
nicholassaylor approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not find a use of it either and as far as I could tell, the page was equivalent before and after

black-sliver
black-sliver approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither

@Berserker66 Berserker66 merged commit 492e3a3 into main Nov 29, 2024
21 checks passed
@Berserker66 Berserker66 deleted the webhost_delete_showdown_templates branch November 29, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Berserker66 @black-sliver @nicholassaylor @Exempt-Medic