Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aquaria Fixing some bugs #4057

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Aquaria Fixing some bugs #4057

merged 2 commits into from
Oct 15, 2024

Conversation

tioui
Copy link
Collaborator

@tioui tioui commented Oct 14, 2024 •
edited
Loading

What is this fixing or adding?

There was some bugs in the logic (including a game breaking one). This PR fixes them.

How was this tested?

  • Testing with unit tests
  • Generate 100 single slot worlds
  • Run the game with a generated world

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Oct 14, 2024
@tioui tioui added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Oct 14, 2024
ScipioWright
ScipioWright approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk the logic of the game. The changes look like fixes for logic issues and follow the same formatting as the existing code. That's good enough for me to approve.

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 14, 2024
palex00
palex00 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@palex00 palex00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully generated and am aware of why these logic changes were made. These are all things that could cause softlocks so they're critical fixes.

@NewSoupVi NewSoupVi merged commit af0b5f8 into ArchipelagoMW:main Oct 15, 2024
18 checks passed
@tioui tioui deleted the bug_fixes branch December 16, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@palex00 palex00 palex00 approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tioui @ScipioWright @palex00 @NewSoupVi