Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aquaria: Adding slot data for poptracker #4056

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

tioui
Copy link
Collaborator

@tioui tioui commented Oct 14, 2024

What is this fixing or adding?

Adding options to slot data to make the Poptracker work.

How was this tested?

  • Unit testing,
  • 10 generations
  • Starting a game
  • Making sure the tracker get the values

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Oct 14, 2024
@tioui tioui added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 14, 2024
Copy link
Contributor

@palex00 palex00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am the tracker maker. I tested this. It gives me the things.

"bind_song_needed_to_get_under_rock_bulb": bool(self.options.bind_song_needed_to_get_under_rock_bulb),
"no_progression_hard_or_hidden_locations": bool(self.options.no_progression_hard_or_hidden_locations),
"light_needed_to_get_to_dark_places": bool(self.options.light_needed_to_get_to_dark_places),
"turtle_randomizer": self.options.turtle_randomizer.value,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥴 why is the } on the same indentation level lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aesthetic reasons

@NewSoupVi NewSoupVi merged commit 618564c into ArchipelagoMW:main Oct 14, 2024
18 checks passed
@palex00 palex00 deleted the aquaria-slot-data branch October 14, 2024 17:24
tioui added a commit to tioui/Archipelago that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants