-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Allow Option References and Math in YAML Option Values #4049
Open
Vertraic
wants to merge
14
commits into
ArchipelagoMW:main
Choose a base branch
from
Vertraic:YamlMath
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
11481ae
Added functionality to handle math/option references in yamls through
Vertraic a6df17a
Added minimum/maximum value limits to yaml math operations for security
Vertraic 82e3648
Updated lufia2ac TestCustomItemPool to pass the new format to update_…
Vertraic ef9c348
Updated lufia2ac TestCustomItemPool to pass the new format to handle_…
Vertraic a82d7d6
Merge branch 'YamlMath' of https://github.com/Vertraic/Archipelago.gi…
Vertraic fd0dfc8
Updated advanced_settings_en.md with usage instructions for this upda…
Vertraic 4140760
use a `name_resolver` function to keep `Option` specifics out of the …
beauxq d9af9bc
Made most recommended changes by beauxq.
Vertraic 6552cc0
Merge branch 'YamlMath' into name-resolver
beauxq 9208ba0
Merge pull request #1 from beauxq/name-resolver
Vertraic a68c596
Fix applied to Generate.py to correct a mutable default.
Vertraic d5e8660
Merge branch 'main' into YamlMath
Vertraic f37e062
Fixed missed variable updates from conversion to choice_group.
Vertraic e3fa262
Merge branch 'YamlMath' of https://github.com/Vertraic/Archipelago.gi…
Vertraic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR author is already aware of this, but this is a note to other reviewers.
This isn't a good place for this math parsing code, but it's not a lot worse than any other place that's available.
It would be good to put it in its own module as a sub-module to
Utils
#4032