Yacht Dice: Fix logic (again) so that score doesn't drop when receiving item

[spinerak]

15/10/2024: ready for review

What is this fixing or adding?

There was an instance of score in logic dropping when receiving an item...
After investigating, there were two ways this could happen:

• Getting an extra Roll would shift the order of categories in a bad way, so that the order becomes worse and score decreases.
• I trimmed the simulation results, which made some categories with x dice and y rolls, better than the category with x dice and y+1 rolls.

To counter the above issues, we:

• now fix the number of rolls to 4 when calculating the order of categories.
• ran the trimmed simulation results through a script that fixes consecutive score distributions that were not stochastically dominant ("strictly better").

As a bonus, I swapped two for-loops in add_distributions which leads to a 10% decrease in total running time.

How was this tested?

This was tested on 29000+ default yaml single-player games and a couple of non-default single-player games.
The website and game are ready for either version :3

[spinerak]

@NewSoupVi I should probably ping you here just to let you know :)
Let me know if there are some strict deadlines for submitting this one!

[NewSoupVi]

Ftr, I'm not that bothered about this one making 0.5.1, because it is quite rare. But if we can make it happen it would be preferrable ofc

[spinerak]

Agreed, the issue is rare and it feels strange to have all generations be a bit slower to avoid a 1 in 10000+ error.
For 0.5.1, I only find #3967 important, this fixes stuff in the setup guide.

[spinerak]

Update:
There were some scores in the weights that had probability 0 to happen. I've removed them.
Did 1000 default-yaml test runs too.