DS3: Make your own region cache #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
nex3
approved these changes
Oct 9, 2024
Exempt-Medic
added
the
is: bug/fix
NewSoupVi
approved these changes
Oct 11, 2024
NewSoupVi
added a commit
that referenced
this pull request
Oct 11, 2024
This reverts commit 2751ccd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
https://discord.com/channels/731205301247803413/731214280439103580/1293370421026230350
Instead of checking the region cache, make your own and check that. Also just stops using the weird
anyHow was this tested?
Literally not at all in any way.