WebHost: Fix too-many-players error not showing #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: webhost
black-sliver
added
the
is: bug/fix
black-sliver
force-pushed
the
fix-webhost-too-many-players
branch
from
76e3fbc to
5cf6f82
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
black-sliver
force-pushed
the
fix-webhost-too-many-players
branch
from
5cf6f82 to
93032e7
Compare
|
Think i got it |
Exempt-Medic
approved these changes
Oct 5, 2024
Berserker66
approved these changes
Oct 5, 2024
DestinyPlayer
added a commit
to DestinyPlayer/Archipelago-stellaris-world
that referenced
this pull request
Oct 7, 2024
WebHost: Fix too-many-players error not showing (ArchipelagoMW#4033)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
"generating of multiworlds is limited to X players" error is currently not showing because the code path does not return a response.
This change is fixing it by using a redirect back to the form, which then shows the error.
Also adds a test for that and 2 more simple tests to validate basic functionality of the generate endpoint.
How was this tested?