OSRS: Add missing indirect conditions #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All entrances to Cooks_Guild and Crafting_Guild and all entrances using special logic for canoes were missing indirect conditions for the regions that the cooking, crafting and woodcutting skill rules require access to.
github-actions
bot
added
the
waiting-on: peer-review
|
The alternative would be removing all the existing registrations of indirect conditions and setting |
5 tasks
Exempt-Medic
added
is: bug/fix
Exempt-Medic
approved these changes
Oct 4, 2024
Exempt-Medic
removed
the
waiting-on: peer-review
digiholic
approved these changes
Oct 23, 2024
Exempt-Medic
added
waiting-on: core-review
NewSoupVi
approved these changes
Oct 28, 2024
|
Really wonder if this specific implementation might not have so many indirect conditions at this point that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
All entrances to Cooks_Guild and Crafting_Guild and all entrances using special logic for canoes were missing indirect conditions for the regions that the cooking, crafting and woodcutting skill rules require access to.
How was this tested?
Ran the spheres test in #3924 multiple times and ran many generations with my own implementation of a missing indirect condition checker (prints a stacktrace on a recursive can_reach(region) call if the indirect condition is missing).