Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Witness: Put progression + useful on some items. #4027

Merged
merged 16 commits into from
Dec 10, 2024
Merged

The Witness: Put progression + useful on some items. #4027

merged 16 commits into from
Dec 10, 2024

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Oct 4, 2024 •
edited
Loading

Not much to say. We discussed a bit which items in Witness fit the new definition of prog+useful, and this is the result of that.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Oct 4, 2024
@NewSoupVi NewSoupVi added the is: enhancement Issues requesting new features or pull requests implementing new features. label Oct 4, 2024
@NewSoupVi NewSoupVi marked this pull request as draft October 4, 2024 01:17
@NewSoupVi
Copy link
Member Author

Deciding whether I actually wanna do this sphere thing

@NewSoupVi
Copy link
Member Author

NewSoupVi commented Oct 4, 2024 •
edited
Loading

Nah I don't. Changed it to be much dumber simpler

It's more reviewable this way anyway, and I have like 12 open Witness PRs so I can't afford unreviewable nonsense lol

@NewSoupVi NewSoupVi marked this pull request as ready for review October 4, 2024 01:30
ScipioWright
ScipioWright approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear how it's being done here, code looks fine, did not test gen

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 4, 2024
@NewSoupVi NewSoupVi merged commit 54a0a5a into ArchipelagoMW:main Dec 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic left review comments

@ScipioWright ScipioWright ScipioWright approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NewSoupVi @Berserker66 @ScipioWright @Exempt-Medic