The Witness: Add "Panel Keys" and "Obelisk Keys" item groups #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
NewSoupVi
added
the
is: enhancement
|
Would "Panels" be a more intuitive name for that group? Alternatively, it should probably be "Door Keys" so they all match. Also, is it intended that "Boat" is in the Panels group for these? |
Exempt-Medic
reviewed
Oct 3, 2024
Yes, but I might make a "Panels" location group, and I don't like the idea that those have the same name
Hmm, I'll think about it
Yes, Boat is a panel key since it unlocks panels. It just so happens that you add it to your game via a different option than shuffle_doors |
ScipioWright
approved these changes
Oct 4, 2024
Exempt-Medic
approved these changes
Oct 4, 2024
Exempt-Medic
added
waiting-on: core-review
Berserker66
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, there is a Doors item group that contains everything that sort of acts like a door (i.e. it is unlocked by a singular "key"), and these items are all implemented the same in the code.
But for the player, there are really three types of """doors""": Doors, Panels, and Obelisks.
This PR splits the "Doors" item group into "Doors", "Panel Keys", and "Obelisk Keys".
The name "Panel Keys" was chosen because "Panels" might be a location group in the future, and the name makes more sense for that.
Tested:
Launched Webhost and glanced at datapackage