Core: no longer log ID ranges on generate #4013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
silasary
approved these changes
Sep 29, 2024
|
|
||
| del item_digits, location_digits, item_count, location_count | ||
| logger.info(f" {name:{longest_name}}: Items: {len(cls.item_names):{item_count}} " | ||
| f"Locations: {len(cls.location_names):{location_count}} ") |
There was a problem hiding this comment.
Do you happen to know what this space is for / if it can be removed?
Suggested change
| f"Locations: {len(cls.location_names):{location_count}} ") | |
| f"Locations: {len(cls.location_names):{location_count}}") |
| f"{max(cls.location_id_to_name):{location_digits}})") | ||
|
|
||
| del item_digits, location_digits, item_count, location_count | ||
| logger.info(f" {name:{longest_name}}: Items: {len(cls.item_names):{item_count}} " |
There was a problem hiding this comment.
I think the | delimiter between the Items and Locations was helpful here
Suggested change
| logger.info(f" {name:{longest_name}}: Items: {len(cls.item_names):{item_count}} " | |
| logger.info(f" {name:{longest_name}}: Items: {len(cls.item_names):{item_count}} | " |
Exempt-Medic
added
the
is: enhancement
Exempt-Medic
added
the
waiting-on: author
nicholassaylor
suggested changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Once ID overlap is fine in clients, we don't need to spend processing on calculating and displaying this information
How was this tested?
with a local gen
If this makes graphical changes, please attach screenshots.