Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timespinner: Fix Typo in Download Location #3997

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Timespinner: Fix Typo in Download Location #3997

merged 1 commit into from
Sep 26, 2024

Conversation

benny-dreamly
Copy link
Contributor

What is this fixing or adding?

I noticed a typo in the check name that was changed while playing a run (funny how I never noticed that before)

How was this tested?

Test generated a seed and confirmed the typo was no longer present in the spoiler log.

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 25, 2024
t3hf1gm3nt
t3hf1gm3nt approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@t3hf1gm3nt t3hf1gm3nt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quickly rushes to git blame to see if it was his fault
woohoo! it was like that before i touched this file LOL
anyway, simple typo is fixed as indicated so LGTM!

@Exempt-Medic Exempt-Medic added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Sep 25, 2024
Exempt-Medic
Exempt-Medic approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple change, and the only instance of "Emporer" in AP, so they're all fixed now. Might need client stuff, but Jarno needs to look at it regardless, so just leaving it to them

@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 25, 2024
@Jarno458
Copy link
Collaborator

Ill allow it!

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Sep 25, 2024
@NewSoupVi NewSoupVi merged commit a043ed5 into ArchipelagoMW:main Sep 26, 2024
18 checks passed
@benny-dreamly benny-dreamly deleted the patch-1 branch September 26, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@t3hf1gm3nt t3hf1gm3nt t3hf1gm3nt approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@Jarno458 Jarno458 Jarno458 approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benny-dreamly @Jarno458 @NewSoupVi @t3hf1gm3nt @Exempt-Medic