Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingo: Add speed boost mode #3989

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hatkirby
Copy link
Collaborator

What is this fixing or adding?

This option replaces all filler items with a Speed Boost item (and removes the Slowness Trap). In-game, the player's default speed will be lowered as if constantly affected by a Slowness Trap, and Speed Boosts must be acquired to temporarily return to normal speed.

How was this tested?

pytest and playtesting with the option both on and off.

Speed boost mode is included with the live game mod as of v4.2.0, so no beta client is needed to test this feature.

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Sep 23, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Sep 23, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the code, it looks good. Did various test generations of different configurations and saw that the new error is properly hit. The Webhost display looks good, the new test passes, and the item ID doesn't overlap. Only two small comments

worlds/lingo/test/TestOptions.py Outdated Show resolved Hide resolved
worlds/lingo/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments were addressed, tested more gens, reaffirming approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants