-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Witness: More control over progressive symbols #3961
base: main
Are you sure you want to change the base?
The Witness: More control over progressive symbols #3961
Conversation
worlds/witness/data/WitnessLogic.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review help:
Every change in the Logic.txt files should fall under these categories.
- Removing "Dots" when "Full Dots" is already there
- Removing "Stars" when "Stars + Same Colored Symbol" is already there
- Removing Symmetry off of the Laser set specifically
This was done with regex replacement and probably does not need to be reviewed too thoroughly
…tart inventory work correctly
This is now waiting on the release of 0.5.1, because I realized I don't want to mess with the beta client any further, since I might have to release it soon |
This fails with itemlinks (just putting the comment here so it can be here too) |
Haven't tested it, but this should be fixed by #3999 (which is merged) |
Add "Progressive Shapers", "Progressive Squares" and "Progressive Line-Counting Symbols".
Also adds more configurability:
The current behavior can be expressed through these new options, and that's how the defaults for them were chosen.
Also removes the unused "Invisible Dots" item.
Also removes unused symbols from WitnessLogicExpert.txt
To achieve this, the progressive items code needed to be adjusted to be per-slot, which makes this PR somewhat big.
Drafted until 0.5.1 releases & the dust settles on it, at which point I will release a beta client that is compatible with these options.