Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LADX: tweak in-game hints #3920

Merged
merged 3 commits into from
Dec 5, 2024
Merged

LADX: tweak in-game hints #3920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2fa97f
dont show local player name in hint
threeandthreee Sep 11, 2024
14f696c
add option to disable hints
threeandthreee Sep 11, 2024
4b4a40a
Merge branch 'main' into ladx/hint-tweaks
NewSoupVi Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion worlds/ladx/LADXR/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,8 @@ def generateRom(args, world: "LinksAwakeningWorld"):
our_useful_items = [item for item in our_items if ItemClassification.progression in item.classification]

def gen_hint():
if not world.options.in_game_hints:
return 'Hints are disabled!'
chance = world.random.uniform(0, 1)
if chance < JUNK_HINT:
return None
Expand All @@ -286,7 +288,7 @@ def gen_hint():
else:
location_name = location.name

hint = f"{name} {location.item} is at {location_name}"
hint = f"{name} {location.item.name} is at {location_name}"
if location.player != world.player:
# filter out { and } since they cause issues with string.format later on
player_name = world.multiworld.player_name[location.player].replace("{", "").replace("}", "")
Expand Down
9 changes: 9 additions & 0 deletions worlds/ladx/Options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,13 @@ class Warps(Choice):
default = option_vanilla


class InGameHints(DefaultOnToggle):
"""
When enabled, owl statues and library books may indicate the location of your items in the multiworld.
"""
display_name = "In-game Hints"


ladx_option_groups = [
OptionGroup("Goal Options", [
Goal,
Expand All @@ -518,6 +525,7 @@ class Warps(Choice):
TradeQuest,
Rooster,
TrendyGame,
InGameHints,
NagMessages,
BootsControls
]),
Expand Down Expand Up @@ -574,6 +582,7 @@ class LinksAwakeningOptions(PerGameCommonOptions):
nag_messages: NagMessages
ap_title_screen: APTitleScreen
boots_controls: BootsControls
in_game_hints: InGameHints

warp_improvements: Removed
additional_warp_points: Removed
Loading