TUNIC: Grass Randomizer #3913
Open
TUNIC: Grass Randomizer #3913
+8,125
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve location names
* Backport changes to grass rando * add_rule instead of set_rule for the special cases, add special cases for back of swamp laurels area cause I should've made a new region for the swamp upper entrance * Remove item name group for grass
- Also ignore grass fill for single player games
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: enhancement
ScipioWright
approved these changes
Sep 9, 2024
qwint
approved these changes
Sep 9, 2024
qwint
reviewed
Sep 9, 2024
Co-authored-by: Scipio Wright <[email protected]>
- non-grass rando games were accidentally seeing grass items get shuffled in as filler, which is funny but probably shouldn't happen
hesto2
suggested changes
Oct 23, 2024
Co-authored-by: Scipio Wright <[email protected]>
hesto2
approved these changes
Nov 9, 2024
ScipioWright
added
waiting-on: core-review
ScipioWright
reviewed
Dec 6, 2024
Co-authored-by: Exempt-Medic <[email protected]> Co-authored-by: Scipio Wright <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
worlds/tunic/__init__.py
Outdated
Comment on lines
380
to
385
| unfilled_locations = [loc for loc in multiworld.get_unfilled_locations_for_players( | ||
| location_names=[], players=tunic_players_with_grass) if loc.progress_type != LocationProgressType.PRIORITY | ||
| and loc.name not in reserved_locations] | ||
| grass_filler_items: List[TunicItem] = [] | ||
| for world in tunic_grass_worlds: | ||
| grass_filler_items.extend(world.local_filler) |
There was a problem hiding this comment.
You could reorder this part and add an early return just so that you aren't calling get_unfilled_locations_for_players when it isn't needed.
Suggested change
| unfilled_locations = [loc for loc in multiworld.get_unfilled_locations_for_players( | |
| location_names=[], players=tunic_players_with_grass) if loc.progress_type != LocationProgressType.PRIORITY | |
| and loc.name not in reserved_locations] | |
| grass_filler_items: List[TunicItem] = [] | |
| for world in tunic_grass_worlds: | |
| grass_filler_items.extend(world.local_filler) | |
| grass_filler_items: List[TunicItem] = [] | |
| for world in tunic_grass_worlds: | |
| grass_filler_items.extend(world.local_filler) | |
| if not grass_filler_items: | |
| return | |
| unfilled_locations = [loc for loc in multiworld.get_unfilled_locations_for_players( | |
| location_names=[], players=tunic_players_with_grass) if loc.progress_type != LocationProgressType.PRIORITY | |
| and loc.name not in reserved_locations] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds Grass Randomizer as an option for TUNIC.
Grass Randomizer adds over 6,000 bushes/pieces of grass as checkable locations that have the potential to give items when cut down.
By default, at least 95% of the grass/filler items are required to be kept local or shuffled among other TUNIC slots with Grass Randomizer enabled. The host can turn off this restriction if they wish by changing the
limit_grass_randosetting in the host.yaml file to false.How was this tested?
Several playtests over the last two months using a beta version of the randomizer mod in the Tunic AP channel, with continuous updates and bugfixes based on feedback.
If this makes graphical changes, please attach screenshots.