Zillion: use "new" settings api and cleaning

[beauxq]

What is this fixing or adding?

#3848 was the motivation for this,
but then I found a bunch of other stuff to clean up too.

• a bunch of double quotes instead of single quotes
• a bunch of @override decorators
• removed a deprecated Logging.warn
• fixed some builtin shadowing
• fixed a few minor typing issues

How was this tested?

played a game

[black-sliver]

Have not tested, but code looks good.

The PR title is a bit confusing though, out of the 58 changed lines only 1 happens to match the title :P

If you don't see a reason to merge it now, I think I'd wait for a decision on 3848 - I believe we want to merge that right after 0.5.1 is out and have worlds fail.

[beauxq]

out of the 58 changed lines only 1 happens to match the title

It says "and cleaning".

[black-sliver]

One comment, everything else looks good code-wise. Did not test anything since the non-typing changes are very few and I am assuming you tested gen an item links.

[black-sliver]

I has question: can a non-empty abstract set here be a frozenset?
If not, wouldn't an assert be better? You copy it and then assign it back, which seems fragile.
Alternatively group["players"] = group_players = set(group["players"]) would be an option?

[beauxq]

Yeah, it did seem a little more fragile to separate those assignments.
I changed it to group["players"] = group_players = set(group["players"])

Even if the current code might not allow the frozenset with items, that seems more like an implementation detail that I shouldn't rely on.

I generated a few seeds with item links and looked at spoilers after this change.

[beauxq]

And I did test another playthrough after the more recent typing changes.
And I found that this is important: #4280
It might be better to merge that before this.