Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Mention explicit_indirect_conditions & "Menu" -> origin_region_name #3887

Merged
merged 7 commits into from
Nov 29, 2024
Merged

Docs: Mention explicit_indirect_conditions & "Menu" -> origin_region_name #3887

merged 7 commits into from
Nov 29, 2024

Conversation

NewSoupVi
Copy link
Member

@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 5, 2024
@NewSoupVi NewSoupVi changed the title Docs: Mention explicit_indirect_conditions Docs: Mention explicit_indirect_conditions & "Menu" -> origin_region_name Sep 5, 2024
nicholassaylor
nicholassaylor approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the docs to the docstrings and PRs and everything matches. LGTM

docs/world api.md Outdated Show resolved Hide resolved
@NewSoupVi @nicholassaylor
Update docs/world api.md
2cbe302 
Co-authored-by: Nicholas Saylor <[email protected]>
@Exempt-Medic
Copy link
Member

You'll want to also update line 469

  • additions to the regions list: at least one called "Menu"

Exempt-Medic
Exempt-Medic approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NewSoupVi NewSoupVi added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 15, 2024
Berserker66
Berserker66 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@Berserker66 Berserker66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@NewSoupVi NewSoupVi merged commit 5d30d16 into main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NewSoupVi @Exempt-Medic @Berserker66 @nicholassaylor