Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TUNIC: Modify UT support to make a better pattern #3860

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

TUNIC: Modify UT support to make a better pattern #3860

wants to merge 12 commits into from

Conversation

ScipioWright
Copy link
Collaborator

What is this fixing or adding?

Adds using_ut and passthrough to the world class, so I can just store it there once and reference it later instead of doing the if has attr: if tunic in thing: over and over again

How was this tested?

Ran universal tracker (after changing it from sweep_for_events to sweep_for_advancements), made sure it didn't break regardless of which slot I connected to.

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Aug 31, 2024
Exempt-Medic
Exempt-Medic approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty simple refactor, just checked that the game still gens and looked over the changes.

@Exempt-Medic Exempt-Medic added the is: refactor/cleanup Improvements to code/output readability or organizization. label Sep 1, 2024
qwint
qwint approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple refactor, not even really UT related lol, but everything looks equivalent

purely a code review, no tests/gens/games run on the branch

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 10, 2024
@Berserker66
Copy link
Member

I don't see using_ut being set to True ever, which seems wrong.

@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Nov 29, 2024
@ScipioWright ScipioWright removed the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@qwint qwint qwint approved these changes

Assignees
No one assigned
Labels
is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScipioWright @Berserker66 @qwint @Exempt-Medic