Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Witness: Add Fast Travel Option #3766

Merged
merged 5 commits into from
Nov 29, 2024
Merged

The Witness: Add Fast Travel Option #3766

merged 5 commits into from
Nov 29, 2024

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Aug 11, 2024 •
edited
Loading

It's just a toggle option that gets added to slot data (which happens automatically for my options :D).

The important stuff is in the client. This is the new release that supports this feature:
https://github.com/NewSoupVi/The-Witness-Randomizer-for-Archipelago/releases/tag/v7.0.0p5

Also rename "Swamp Near Platform" to "Swamp Platform" because that's a better name for where the warp goes

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Aug 11, 2024
@NewSoupVi NewSoupVi added the is: enhancement Issues requesting new features or pull requests implementing new features. label Aug 11, 2024
Exempt-Medic
Exempt-Medic approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one option and a single region rename. The change LGTM and functions in generations and with the client. The list of warps is accurate (this will need to be updated in Variety depending on the order those get merged, but that's fine)

Zunawe
Zunawe approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@Zunawe Zunawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Don't see any leftover instances of the old location name, and the option does what it needs to.

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Sep 3, 2024
@NewSoupVi
Copy link
Member Author

This needs to be updated for Variety

@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Oct 15, 2024
@NewSoupVi
Copy link
Member Author

Has been updated for Variety rando

@NewSoupVi NewSoupVi removed the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Oct 19, 2024
@NewSoupVi NewSoupVi merged commit 82260d7 into ArchipelagoMW:main Nov 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@Zunawe Zunawe Zunawe approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NewSoupVi @Berserker66 @Zunawe @Exempt-Medic