Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Witness: Fix extremely late crash when Nothing items exist #3749

Closed
wants to merge 4 commits into from
Closed

The Witness: Fix extremely late crash when Nothing items exist #3749

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd262e3
This PR doesn't need to be so complicated
NewSoupVi Aug 9, 2024
54b50b1
Merge remote-tracking branch 'upstream/main' into area_hint_none_fix
NewSoupVi Aug 19, 2024
51927a3
Merge branch 'main' into area_hint_none_fix
NewSoupVi Aug 24, 2024
ba46fa3
Merge branch 'main' into area_hint_none_fix
NewSoupVi Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions worlds/witness/hints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,8 @@ def word_area_hint(world: "WitnessWorld", hinted_area: str, area_items: List[Ite
any local lasers to be found in this area.
"""

area_items = [item for item in area_items if item is not None]

local_progression = sum(item.player == world.player and item.advancement for item in area_items)
non_local_progression = sum(item.player != world.player and item.advancement for item in area_items)

Expand Down
Loading