Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorio: Introduce progressive-fluid-handling #3743

Conversation

Toby-Lawrance
Copy link

What is this fixing or adding?

progressive-train-network currently has the order of: railway (trains and rails and cargo wagons) -> fluid-wagon (fluid wagons) -> automated-rail-transportation (train-stops) -> rail-signals (Chain and Standard Rail signals) -> braking-force-1-7 (Trains slow down faster)

This adds a new manual progressive chain named "progressive-fluid-handling"

progressive-fluid-handling has two components: fluid-handling -> fluid-wagon

progressive-train-network is shortened in chain by one to: railway -> automated-rail-transportation -> rail-signals -> braking-force-1-7

How was this tested?

Tested with a short 2 person game to verify hints worked. "fluid-handling" was not left over separate. technologies were awarded in the correct order and that no errors were presented.

If this makes graphical changes, please attach screenshots.

N/A

Note: Poll held on AP discord for approval of this change: https://discord.com/channels/731205301247803413/827139809763262525/1270657132680843276

@Toby-Lawrance Toby-Lawrance marked this pull request as ready for review August 8, 2024 08:27
@NewSoupVi NewSoupVi added waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. is: enhancement Issues requesting new features or pull requests implementing new features. labels Aug 8, 2024
@Exempt-Medic Exempt-Medic added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Aug 8, 2024
@Berserker66
Copy link
Member

I remember old clients breaking if the order of progressive rows changes, hence new ones were added to the end. This adds it in the middle. So, that definitely needs testing.

@Berserker66
Copy link
Member

As nobody did the backwards compat testing, I will probably lump this in with 2.0/Space Age, which will likely forego backwards compat anyway.

@Exempt-Medic Exempt-Medic added waiting-on: author Issue/PR is waiting for feedback or changes from its author. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Nov 28, 2024
@Toby-Lawrance
Copy link
Author

Just noticed it had been snuck into the 2.0 update directly. Closing

@Toby-Lawrance Toby-Lawrance deleted the progressive-fluid-handling branch December 4, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants