Stardew Valley - Prize Ticket and Mystery Box grinding requires the abilty to redeem them #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
agilbert1412
added
the
is: bug/fix
Exempt-Medic
reviewed
Aug 2, 2024
Comment on lines
+46
to
+47
| return self.logic.and_(opening_rule, mystery_box_rule, | ||
| book_of_mysteries_rule, time_rule,) |
There was a problem hiding this comment.
Any reason this isn't just one line?
There was a problem hiding this comment.
Not particularly, any reason it should be?
There was a problem hiding this comment.
Just seems odd to me, since it's a different formatting from before and also it has the final , which none of the other lines in this file do
There was a problem hiding this comment.
The previous formatting was one argument per line to minimize potential git conflicts. We should stick to it or change it to the standard "all arguments on the same line". Two arguments is quite unconventional...
Exempt-Medic
approved these changes
Aug 3, 2024
Jouramie
approved these changes
Aug 5, 2024
Exempt-Medic
added
waiting-on: core-review
NewSoupVi
approved these changes
Aug 31, 2024
Jouramie
deleted the
StardewValley/PrizeTicketUsageRequiresLewisHouse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Owning a Mystery Box or a Prize Ticket isn't enough to get rewards from it. Mystery boxes must be opened at the blacksmith, and Prize tickets must be redeemed at the prize machine in Lewis's house.
With Entrance Randomization, these two areas are not always available. But they were missing from the condition when grinding these items. Now I added it
Note: You do not require these areas to own a mystery box or prize ticket, for checks like "Shipsanity: X". You only need access to claim these items to use the rewards from them, which at the moment includes very few things. The most notable one is the book "Friendship 101", which was the reason the bug was discovered.
How was this tested?
Unit tests and local generation with spheres