Pokemon Emerald: Make use of NamedTuple._replace
#3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Zunawe
added
is: refactor/cleanup
Exempt-Medic
approved these changes
Aug 20, 2024
qwint
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
under the assumption that NamedTuple._replace() is better than dataclasses and/or creating new ones from existing values,
all changes look good and match existing functionality.
was purely a code review. I did some local testing with NamedTuple._replace to make sure I understood the format correctly, but did not run any tests/gens/etc. on the branch
Zunawe
added
waiting-on: core-review
NewSoupVi
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Uses
_replaceinstead of rebuilding the class by passing in each property. If I was aware of_replacewhen this was written, I was at least under the impression that it's somewhat improper to use because of the leading underscore. But it's apparently the recommended solution for what's happening here.How was this tested?
Generated on
mainand on this branch with the same seed and all relevant randomization turned on and compared the file hashes of the resulting patched ROM. So these changes should all have been hit and resulted in the same values in the output.