Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Witness: Advanced Hints Options #3706

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

The Witness: Advanced Hints Options #3706

wants to merge 23 commits into from

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Jul 28, 2024 •
edited
Loading

Some ppl were complaining about the hint distribution

I think it's fine as it is, and don't really know how I'd improve it for them without making it worse for me

So I went "do it yourself" and just made a boatload of options in a collapsed option group

This is basically just the current hints system but with options making everything that is reasonable to be configurable, configurable :)

Also added a boatload of debug logging to the whole hints process.

@NewSoupVi NewSoupVi marked this pull request as draft July 28, 2024 20:07
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jul 28, 2024
@NewSoupVi NewSoupVi added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: other Issue/PR is waiting for something else, like another PR. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jul 28, 2024
@NewSoupVi NewSoupVi mentioned this pull request Jul 28, 2024
Draft
@NewSoupVi NewSoupVi force-pushed the advanced_hint_settings branch from dedaca2 to 1e06005 Compare August 20, 2024 09:56
@NewSoupVi NewSoupVi marked this pull request as ready for review August 20, 2024 09:56
@NewSoupVi NewSoupVi added waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. and removed waiting-on: other Issue/PR is waiting for something else, like another PR. labels Aug 20, 2024
NewSoupVi
NewSoupVi commented Aug 24, 2024
View reviewed changes
worlds/witness/hints.py Outdated Show resolved Hide resolved
NewSoupVi
NewSoupVi commented Nov 14, 2024
View reviewed changes
worlds/witness/hints.py Outdated Show resolved Hide resolved
@NewSoupVi NewSoupVi added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Nov 26, 2024
@NewSoupVi NewSoupVi removed the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NewSoupVi