Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Dev FAQ - About indirect conditions #3698
Docs: Dev FAQ - About indirect conditions #3698
Changes from 2 commits
db5be6a
295e719
f9b07a5
8420c72
205fa71
3a70bf9
850033b
e74e472
9ec1f8d
49394be
1d8d04e
cf3d4ff
663b5a2
a1779c1
8cefe85
df1f3dc
153f454
ce8d254
a2ba2f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird ro say "the performance upsides" when they aren't mentioned anywhere. I think some of the structure/paragraphing here jumps around from topic quickly in ways thar carry assumptions about the dev's knowing why the subject is changing. I don't think how it is now is particularly bad but I'd have to think a good bit to come up with a structure I think would be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is "For performance reasons, ..." some paragraphs before this
Might not be direct enough, idk