Launcher: support Component icons inside apworlds

[qwint]

What is this fixing or adding?

Add kivy overrides to allow AsyncImage source paths of the format ap:worlds.module/subpath/to/data.png that use pkgutil to load files from within an apworld

How was this tested?

locally edited the a hat in time world to use icon_paths['yatta'] = f"ap:{__name__}/data/yatta.png" instead of the existing icon_paths value, moving said png to inside a "data" folder in the world, and opened the launcher with:

• the world unzipped
• the world zipped as an apworld in /worlds
• the world zipped as an apworld in /custom_worlds

and all displayed the icon, also tested

• with the original icon, loaded quickly with no issue
• with an upscaled icon, which tripped zipbomb protection and did not load
• with a less upscaled icon, which took a few seconds to load, in which the launcher opened, displayed a loading icon, and was interactable until the image finished loading and replaced the loading icon as expected

If this makes graphical changes, please attach screenshots.

Testing notes

feel free to reference the branch https://github.com/qwint/Archipelago/tree/apAsyncImage_test to see the ahit changes for testing

[beauxq]

If we're overriding load, why aren't we returning the same type that load returns?
It looks like the default load returns an instance of Image, while the new load would return an instance of ImageLoaderBase (which itself has a load function that returns a list of ImageData).
Can you explain how this works?

[qwint]

if ImageLoader.load() needs to load asynchronously it returns an ImageLoaderBase that can handle the request
https://github.com/kivy/kivy/blob/master/kivy/core/image/__init__.py#L454
this is mimicking that workflow but just short-circuiting it as early as possible because the current loader picking code in kivy cannot handle the information we need in the filename

[beauxq]

variable name

• This isn't a type, so this isn't the right capitalization pattern for it.
• Is there any reason for people to import this from the module and use it directly? If not it should begin with underscore (_)

maybe _original_load or _original_image_load or _original_image_loader_load

[ScipioWright]

Can confirm it works, making a similar change in the Animal Well apworld.
While I don't understand the code changes all that much, the syntax looks fine to me.

[benny-dreamly]

read the code and it looks pretty good. I don't know kivy at all, but I do know how to use PIL to display images, and that syntax looks correct. otherwise LGTM.

didn't test it however

[nicholassaylor]

Is this something that we want to document in https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/apworld%20specification.md ?

Mentioning #3387 for posterity

[beauxq]

I didn't test it, but I looked over the code a bit.

[qwint]

bad news: I have learned that PIL is not included in frozen so this did not function when frozen
good news: I have learned how to find a native kivy loader that can load a bytes io object without needing a path on disk

retested the same apAsyncImage_test branch on source and frozen and now it works in both

[massimilianodelliubaldini]

Great feature, especially for custom/unsupported apworlds!