Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Witness: Small naming inconsistencies #3618

Merged
merged 2 commits into from
Jul 24, 2024
Merged

The Witness: Small naming inconsistencies #3618

merged 2 commits into from
Jul 24, 2024

Conversation

NewSoupVi
Copy link
Member

Location "Mountain Bottom Floor Elevator Closer Left" has been renamed to "Mountain Bottom Floor Elevator Close Left"

WitnessEvent location 158903 has been reassigned to id 159803, because WitnessEvents are supposed to start with 1598
(Don't think about it too hard, that ID is discarded anyway, but like, yeah)

@NewSoupVi NewSoupVi added is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jul 3, 2024
Exempt-Medic
Exempt-Medic approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using one of these changes on my own for months and the other one looks fine to me and doesn't appear anywhere else. This LGTM

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jul 3, 2024
@NewSoupVi NewSoupVi merged commit dc50444 into ArchipelagoMW:main Jul 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NewSoupVi @Berserker66 @Exempt-Medic @ScipioWright