CommonClient: fix bug when using Connect button without a disconnect #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnect does to fix an issue where losing connection would make you unable to connect to a different server
github-actions
bot
added
affects: core
Jouramie
approved these changes
Jul 4, 2024
kvui.py
Outdated
| @@ -599,6 +599,7 @@ def connect_button_action(self, button): | |||
| self.ctx.username = None | |||
| async_start(self.ctx.disconnect()) | |||
| else: | |||
| self.ctx.username = None | |||
There was a problem hiding this comment.
Since self.ctx.username = None is in both branch of the if self.ctx.server, would it be better to extract it?
There was a problem hiding this comment.
didn't notice this haha, fixed
invalid passwords trigger a different workflow where you can fix it, nothing (in that specific workflow) for clearing and fixing a slot, so I think that's fine |
Exempt-Medic
added
the
is: bug/fix
Exempt-Medic
approved these changes
Jul 20, 2024
Exempt-Medic
added
waiting-on: core-review
black-sliver
approved these changes
Jul 21, 2024
There was a problem hiding this comment.
Change looks safe and I am gonna trust the 2 peer reviews.
The password thing is addressed in #3641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
makes the kivy connect button do the same username forgetting that /connect does to fix an issue where losing connection would make you unable to connect to a different server
How was this tested?
With two servers that have different valid slot names
If this makes graphical changes, please attach screenshots.