Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLSS: Fix for missing cutscene trigger #3599

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

jamesbrq
Copy link
Contributor

What is this fixing or adding?

Fixes issues where the Beanstar Quest cutscene would not play under certain circumstances.
Changes based on commit 4a9dbdb in the standalone randomizer repo.

How was this tested?

ASM was patched and cutscene would and would not play when expected.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 30, 2024
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jun 30, 2024
Copy link
Collaborator

@beauxq beauxq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asm change looks simple

@NewSoupVi NewSoupVi merged commit bfac100 into ArchipelagoMW:main Jul 5, 2024
11 checks passed
@jamesbrq jamesbrq deleted the mlss-asm branch July 7, 2024 03:08
@jamesbrq jamesbrq restored the mlss-asm branch July 12, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants