Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muse Dash: Update installation guides to recommend installing v0.6.1. #3594

Merged

Conversation

DeamonHunter
Copy link
Collaborator

What is this fixing or adding?

The current version of MelonLoader (v0.6.4) causes internal errors while loading dlls required for network connectivity. (DLL Not Found: System.Security.Permissions)

This rewrites the guides to explicitly mention installing v0.6.1

How was this tested?

Checked rendering on webhost.

@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 27, 2024
@DeamonHunter
Copy link
Collaborator Author

Paging @ShinyNT to double check spanish google translate changes.

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English changes LGTM. I don't know Spanish

Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me, just removing some text and adding one new line.
I know just enough spanish to verify the spanish changes too.

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 27, 2024
Copy link
Contributor

@ShinyNT ShinyNT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor spanish changes, everything else is good

- Puedes encontrar la carpeta en Steam buscando el juego en tu biblioteca, haciendo clic derecho sobre el y elegir *Administrar→Ver archivos locales*.
- Si haces clic en la barra superior que te indica la carpeta en la que estas, te dará la dirección de ésta para que puedas copiarla. Al pegar esa dirección en la ventana que **MelonLoader** abre, irá automaticamente a esa carpeta.
3. Ejecuta el juego una vez, y espera hasta que aparezca la pantalla de inicio de Muse Dash antes de cerrarlo.
4. Descarga la última version de [Muse Dash Archipelago Mod](https://github.com/DeamonHunter/ArchipelagoMuseDash/releases/latest) y extraelo en la nueva carpeta creada llamada `/Mods/`, localizada en la carpeta de instalación de Muse Dash.
3. Desmarque "Latest" y seleccione v0.6.1. Luego haz clic en "install".
Copy link
Contributor

@ShinyNT ShinyNT Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "Desmarca" instead of "Desmarque" and "selecciona" instead of "seleccione"
current is extremely formal spanish verb forms, which doesn't go with the archipelago guide context (also inconsistent with the rest of the guide)
other than that, all good, thanks for taking care of it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied. Thanks for fixing the google translate part haha.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, google never gets context right

@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Jun 27, 2024
@DeamonHunter DeamonHunter removed the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Jun 27, 2024
Copy link
Contributor

@ShinyNT ShinyNT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spanish look good now

@NewSoupVi NewSoupVi merged commit 1c817e1 into ArchipelagoMW:main Jun 29, 2024
11 checks passed
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
…ArchipelagoMW#3594)

* Update installation guides to recommend installing v0.6.1.

* Fix spanish spacing.

* Apply spanish changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants