WebHost: Disable flask caching if DEBUG is enabled.
#3581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
is: enhancement
github-actions
bot
added
the
waiting-on: peer-review
NewSoupVi
approved these changes
Jun 23, 2024
|
My problem with this solution is that if you want to debug caching solutions, this is now impossible. I would prefer adding documentation to the config example yaml to set |
|
Definitely fair. I think I'll just close this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This disables flask caching of templates when
DEBUGis set toTruein the webhost config file, which allows hotreloading of jinja templates without restarting the flask app.How was this tested?
Ran webhost with
DEBUGenabled and disabled and confirmed caching is disabled inDEBUGmode.If this makes graphical changes, please attach screenshots.
N/A