Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OoT: Turn Logic Tricks into an OptionSet #3551

Merged
merged 5 commits into from
Nov 29, 2024
Merged

OoT: Turn Logic Tricks into an OptionSet #3551

merged 5 commits into from
Nov 29, 2024

Conversation

Exempt-Medic
Copy link
Member

@Exempt-Medic Exempt-Medic commented Jun 16, 2024 •
edited
Loading

What is this fixing or adding?

Changes Logic Tricks into an OptionSet as the option does not contain duplicate entries and the order does not matter.

https://discord.com/channels/731205301247803413/884928390421938206/1186332343225561108

How was this tested?

WebHost, unit tests, and doing a generation.

@Exempt-Medic Exempt-Medic requested a review from espeon65536 June 16, 2024 12:37
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 16, 2024
@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jun 16, 2024
@Jouramie
Copy link
Contributor

Not tested, code LGTM.

@NewSoupVi
Copy link
Member

Approval from Espeon is implicit as per https://discord.com/channels/731205301247803413/1214608557077700720/1253206955879694336

@NewSoupVi NewSoupVi removed the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Jun 20, 2024
nicholassaylor
nicholassaylor approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, LGTM

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 27, 2024
@NewSoupVi NewSoupVi merged commit ce78c75 into ArchipelagoMW:main Nov 29, 2024
16 checks passed
@Exempt-Medic Exempt-Medic deleted the patch-2 branch November 30, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@Jouramie Jouramie Jouramie approved these changes

@espeon65536 espeon65536 Awaiting requested review from espeon65536

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Exempt-Medic @Jouramie @NewSoupVi @nicholassaylor