-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Color Picker GUI #3536
base: main
Are you sure you want to change the base?
Core: Color Picker GUI #3536
Conversation
some questions
some comments
some praise
did a light code review and nothing stood out, will probably review a bit more in depth later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realized i didn't actually technically request changes before and i'm at the very least doubling down on the issue of importing kivy before importing kvui, especially after opening #3823
but I also believe the rest of my previous comments need addressing in some way
- the new command echo color is not covered here
- I know the internals are remapping the color names to the alternative color values, but from a GUI perspective changing the color of "black" and "slateblue" is very confusing and takes a lot of trial and error to see the intent of each color group
- you should probably import kvui before kivy so this doesn't happen to you on frozen https://discord.com/channels/731205301247803413/1261299992564469780
FileNotFoundError: [Errno 2] No such file or directory: '\\Archipelago-Branch\\data\\presets\\test.kv'
seems saving a preset needs to handle when data/presets is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my outstanding questions (quoted below) are still unanswered, but I don't think they're showstoppers and the actual issues i found in my previous review are fully resolved
- is it possible to have a way to save without closing?
- I know it's a "Text Color Picker" but it seems kinda silly to not be able to change background colors as well to match
What is this fixing or adding?
Adds a GUI for editing
user.kv
, supports both regular JSONToKivy colors as well as the default white used for labels, with room for further expansion. Also supports creating and loading color presets that can be shared between users.A change to client.kv for supporting coloring Selectable/HintLabel is also included, but not yet a part of Color Picker behavior (as I'd like to support more than just those two).
How was this tested?
Manually. It's a self-contained GUI, so no automated testing was added.
If this makes graphical changes, please attach screenshots.