kvui: add autocompleting new hint text input

[Berserker66]

What is this fixing or adding?

adds a autocompleting new hint text input

How was this tested?

locally, connected with TextClient, not connected with TextClient, and connected with SC2 Client.

If this makes graphical changes, please attach screenshots.

[Ziktofel]

could the items get color depending on type (progression/useful/filler/trap)?

[EmilyV99]

LGTM

[EmilyV99]

could the items get color depending on type (progression/useful/filler/trap)?

Doubtful, since a single item name/id can have different flags in different locations, so that info isn't known without scouting it

[MatthewMarinets]

If you click off the hint textbox / lose focus, then the dropdown disappears (as expected). If it regains focus, however, the dropdown does not come back, forcing a user to potentially remove and re-add a character. This should probably be fixed.

Edit: also, the dropdown registers a selection with all mouse buttons, including middle and right mouse buttons. I'd expect only left mouse button to select. Losing focus of the text box with tab doesn't cause the dropdown to disappear, so I'm no longer sure what conditions exactly cause it to disappear.

Separate issue (though I'm fine to call this a stretch goal/leave for a later PR): I'd expect pressing up/down from the text box to focus one of the dropdown options to let you select one of them with pure keyboard, but this doesn't seem to be the case. The only way to interact with the dropdown is the mouse.

Would also be nice to have fuzzy search so I could search "marnie" to get "marine" or something, but that's even more of a stretch goal.

[MatthewMarinets]

Text within dropdown options should probably be left-aligned rather than centered.

This can avoid visual distance between the input text and resulting options for very wide screens:

And it's probably more usable to see the start of a name rather than the middle for very narrow window sizes relative to item name:

[MatthewMarinets]

Another issue: The text input loses focus after hitting enter, even if the hint failed (e.g. due to a typo). It looks like focus entirely vanishes, so there's no recovering it by spamming tab a bunch of times.

[MatthewMarinets]

This introduces a new mypy issue:

Invalid index type "str | None" for "dict[str, ChainMap[int, str]]"; expected type "str" [index]

[Berserker66]

This is technically purely a typing issue, as the underlying class is a defaultdict. Maybe @ThePhar for comment, as he made the typing.

[MatthewMarinets]

After more testing, I've found some of my code suggestions have minor knock-on effects. Also, arrow-key navigation is rather a big change for code suggestions. I've tossed everything together into a PR into this branch (#3537). Merge at your leisure or pick pieces out if you don't like all of the decisions there.

[Berserker66]

I did try the no focus lost before making this PR, and then deleted the line again as at least personally I did not like it. There is already not enough feedback to what's going on, but at least the focus loss means something at least tried to happen.

[Berserker66]

Now looks like this

I avoid regex as much as possible, and I think color is too heavy handed here. (also means we can repurpose this element somewhere where we want colored entries).
I also avoided storing each item name twice, rejecting the suggestion above.

[MatthewMarinets]

I did try the no focus lost before making this PR, and then deleted the line again as at least personally I did not like it. There is already not enough feedback to what's going on, but at least the focus loss means something at least tried to happen.

There's two parts there: Focus moving away (reasonable imo), and focus going totally undefined so no amount of tabbing can recover it (bug).

I had the command-line client open on the other monitor so I could get feedback from there when testing, but yeah without it the feedback is lacking. The normal pattern here is probably to just clear the text input on entry, though that could get annoying with typos (unless we also add command history to this, which is less useful than commands as there's little reason to hint the same thing repeatedly :/).

[Exempt-Medic]

Briefly looked at the code, but really just did functional testing. The scrolling is a little jittery/flashy, but the feature works great. Tested a few different games and all the items displayed and were filtered properly.

[black-sliver]

I don't like the look of this at all, but it's probably good enough until we switch to kivymd one day.

[black-sliver]

Missing newline at end of file

[ReverM]

Does this discriminate between hint and hint_location? Furthermore, could the list maybe two entries wide so there's more on the screen at once? (the names seem to mostly be smaller than a full line width)
Maybe dynamic wrt to the window's size?