Tests: add test that option classes aren't reused #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
|
Should this ignore Removed? Unsure if they go into Game options by default like other options, but it is the main use I can see of a duplicate class. |
|
it ignores |
alwaysintreble
added
is: enhancement
Exempt-Medic
approved these changes
Aug 26, 2024
|
This should work now btw |
Exempt-Medic
removed
the
waiting-on: world-maintainer
black-sliver
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Prevents worlds from reusing the exact same option class in their available options. This becomes problematic when trying to use Option Groups since all the grouping happens via the actual class and not the dataclass's attributes. Namely #3393
How was this tested?
Ran tests a few times, added a duplicate option and removed it ensuring it behaved how I expected.