Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pokemon Crystal: Implement new game #3494
base: main
Are you sure you want to change the base?
Pokemon Crystal: Implement new game #3494
Changes from 154 commits
3b4f662
44b8719
1acb43e
600b786
d5eb22c
f379b84
05c784a
a3b7dc5
d56fc1d
34868f0
25f81f6
d943c3d
160576b
23f70b4
2dafbac
4d6184d
8a0d64e
97185f2
0a14a70
48c5658
081043a
b914a0f
d0134da
42f5bf2
4db3ef4
f0640bd
6c6dd49
7e01b37
399eedf
740fb36
71cf0d9
29619a7
4ff12e6
c7f8980
47345f4
2fb26e1
b5cf79b
cd10616
2b451c3
0021672
4a8b5e4
2dab232
e72fe27
07898c7
4422a3a
42e66df
cc4611a
a64fdda
4ba8a7b
d66784a
e34f78d
278e856
1a6def5
898001b
d103080
e812db1
3eb15d4
97a956c
fa24b05
8b37f5f
d841922
363a065
4029622
204e8d5
e69f129
495b82d
304c4cc
cc403fe
9d162ac
9c08d3e
8bfcb98
348f780
fb5f842
677b0c3
e8e693f
94cdca5
846a417
6c653b5
307999d
abd8f86
3295118
66126d1
6203e5e
94d7326
dc93e98
8788b0c
9672886
5f7587f
808e364
5abecfe
63fbe2c
2e7f8dc
58372df
ea5a514
3ba70ea
eaa8a64
d1006bc
ae65744
35d5941
7c04709
5a63b63
b1d31d6
c296808
c905885
193aec6
9291ab6
dc931ce
745c60c
44ff22e
256c74c
b205270
07372b4
502ba44
f700ad1
e9ec34e
da526a6
2a02fcb
6184bdf
5d6d3b5
6a7c261
2be066e
774277c
212d2bf
0cde555
26f8ee1
b72d20a
771c422
d6f9739
bce4e03
10630c2
5dd4d16
521f60a
dfda151
f3174f7
e7a9ded
dfb705c
b62766c
c7f21ab
3c80094
ddcb0d4
24f798e
fc86dc7
115ae57
001ab4b
4430351
487be35
4314ba5
eb09bee
a9e4f35
f8062ab
30be979
c5f3056
e403b7e
4a94967
143fea5
b31fedb
6896f90
2f397f2
a9b4d25
885f6e1
adc55e7
0f96773
dd1a9c5
5272270
9425cac
6aca55f
d57d2b2
38240dc
5908e28
c4ea26d
1629f8e
c905def
1352fed
c8f25d5
98374de
05700ad
4019f52
6777a01
b86e70a
6e16950
9ca4779
e2fddb8
0a07c18
a599fce
78bbdc6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default_itempool.append(item)
is faster and (in my opinion) more readable than
default_itempool += [item]
Same for other instances below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always going to be a fan of checking options explicitly against named values rather than relying on the falsiness of the particular option value, but I think I may be in the minority there. I value the safety and readability, but I know others consider it verbose and less elegant.
Disregard if you like it as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I may have made this comment before; I'll try to remember that my opinion has been shared already and stop flagging it, lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be even less characters: if self.options.randomize_startersThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, everything that's been mentioned here is fine as far as core is concerned :)