Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnautica: ability to remove vehicles either from logic or entirely #3437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kedNalatacId
Copy link
Contributor

What is this fixing or adding?

Add 3x new options to Subnautica to allow removing the vehicles either logically or completely.
Also changes rules to use new options syntax rather than old multiworld syntax.

If all vehicles are exluded then "advanced" logic is triggered which operates off of base building instead. The more likely scenario of using seaglide with extra air tanks cannot be tracked logically, so hopefully this suffices.

NOTE: This is dependent on changes to the archipelago subnautica mod which have been PRed.

How was this tested?

Generated many games, played quite a few of them.

Used python3.11. Please let me know if I need to test anything on other versions (and which ones).

If this makes graphical changes, please attach screenshots.

New options:
Screenshot 2024-06-02 at 00 08 04

Example rollover tip (for cyclops, which has extra text):
Screenshot 2024-06-02 at 00 08 41

Updated Vehicle Upgrade Console:
Screenshot 2024-05-05 at 21 19 34

Shield Generator on Vehicle Upgrade Console:
Screenshot 2024-05-05 at 21 19 57

@kedNalatacId kedNalatacId requested a review from Berserker66 as a code owner June 2, 2024 07:24
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 2, 2024
@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jun 2, 2024
@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Aug 20, 2024
@Exempt-Medic
Copy link
Member

This has conflicts

@kedNalatacId
Copy link
Contributor Author

This has conflicts

It's been open for a bit so that's not entirely surprising; i'll try to rebase this (hopefully without failure) sometime soon. Thanks for looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants