Hollow Knight: AP Website Tracker #3422
Conversation
github-actions
bot
added
affects: webhost
Exempt-Medic
added
the
waiting-on: world-maintainer
|
Going to leave this one for @ThePhar to review as I do not use the web tracker, don't really see a downside to have it but not going to rush to review it either and web is not my specialty. Looks neat though |
|
Assigned myself to review after work. |
Exempt-Medic
added
the
is: enhancement
|
@qwint I guess this is your problem now fyi |
There was a problem hiding this comment.
I see the tooltip for Howling_Wraiths/Abyss_Shriek is "Progressive Shriek" but our item group for the two is "Scream"
I suggest following that same naming convention so we don't need to change it when we move to actual Progressive names
Elevator pass should be default on like focus/swim
Why have Progressive Dream Nail and Dreamgate? Dreamgate is the 2nd of the 3 Progressive Dream Nail stages
I'd want the horizontal (cloak/cdash) and vertical (claw/monarch wings) to be grouped together instead of staggered like they are currently
I'm not sure I like the progressive items showing as either the icon for the early form or a checkmark if fully gathered, but I'm not certain what I want it changed to,
My current ideas are:
- always show the icon, for all stages
- show some fraction (i.e. 1/2 then 2/2 progressive fireballs)
- some partial checked icon for stage 1/2, but that would not work for 3 stage progressive items like dreamnail
is there any other webtrackers that have had to handle this? how do they display?
for the per player visual tracker, is there a way to make the background not pure black? It's hard to read
in addition: some of the icons are so greyscale already that the difference between 'off' and 'on' is hard to see, I think a per-icon background (like a square/circle behind the icon) that gets shaded in or not as well would help but I'm open to other suggestions
in addition, the per player visual tracker also shows one icon for cloak when none are collected, even if split cloak is on, can you make the number of icons consistent? (either by always making two icons and have some way to denote full shade cloak, or by compressing the split cloak into one icon ex. mothwing cloak with an R denoting right cloak only, a mothwing cloak with an F denoting full mothwing, a shade cloak with an L denoting left shade cloak with no right dash) I'm open to other designs that keep the icon count the same too.
Can the dreamer icons just be their masks instead of the full body icon? I feel those are more recognizable
| background-size: cover; | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
| } */ |
There was a problem hiding this comment.
i assume this was commented while you were developing and can just be deleted now?
There was a problem hiding this comment.
Oh yes. I'll remove that.
| "Progressive Heart" : ["Fragile_Heart", "Fragile_Heart", "Unbreakable_Heart"], | ||
| "Progressive Greed" : ["Fragile_Greed", "Fragile_Greed", "Unbreakable_Greed"], | ||
| "Progressive Strength" : ["Fragile_Strength", "Fragile_Strength", "Unbreakable_Strength"], | ||
| "Progressive Grimmchild" : ["Grimmchild1", "Grimmchild1", "Grimmchild2", "Grimmchild3", "Grimmchild4"], |
There was a problem hiding this comment.
grimmchild doesn't work as a progressive item in AP
the difference between grimmchild1 and grimmchild2 is 2 tells the game that it should start upgraded so the player doesn't need the grimkin flames, where 1 tells the game to start in 1 form and force the player to upgrade it with the flames in the multiworld
we could still use the different icons for whichever is in the itempool / is sent, but they are not progressive
There was a problem hiding this comment.
I would keep a single icon, barring some plando nonsense there will only ever be 1 grimmchild in the seed
There was a problem hiding this comment.
Sometimes there is Grimmchild 1 and sometimes 2. I could rewrite it in code to just Grimmchild. It is guaranteed that there is just on Grimmchild at a time?
There was a problem hiding this comment.
The progressive is there more for the visual icon. So when Grimmchild1 is in pool then we get that icon, if it's two we get the other. Progression is here more because of using the existing stuff as workaround, independend of progressive behaviour or not in game. (so therefore it makes maybe sense to keep the progression but rename the group to Grimmchild)
There was a problem hiding this comment.
Plando can cause both Grimmchilds to exist. But that can also cause, say, twenty Dream Nail items to exist or 5 version of a progressive item that only has two stages. I believe outside of plando there is only ever one Grimmchild
There was a problem hiding this comment.
https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/hk/__init__.py#L305
yes, either 1 or 2 will be added to the itempool, never both (without things like plando that we shouldn't need to cover for)
regardless it sounds like you understand they don't actually act like progression items, so whichever icons you chose to display is fine by me
I can change that. Are the other group names in the world code so I could take a look for the other groups as well?
Focus/Swim are just checkmarked by default in the multi tracker. So I can do that for Elevator Pass there as well. In the single player tracker the other both are shown just when the option is randomized.
Didn't know that all three are connected together. So I'll change it to Dreamgate as second between the other both.
I don't understand how that is meant / how that is visually expected.
Base is the ALttP tracker. There we have the mail (three stages) and sword (four stages). There is shown just the last/current one in the progression. That looks in my opinion also cleaner than i.e. a 1/2 and so on.
I have used the icons from https://hollowknight.wiki. There they were not other available. I would take a look for another source and change them. |
|
That is how full tracker looks like in ALttP. The bow, mail, shield, sword and gloves are progressive items. The number for the sword is part of the icon.
This is how it look when there is just a few stuff collected so far.
|
|
For the Dreamers, you could use their map pins |
|
Haven't found them before but that are the one I wanted use anyway. I'll replace the current one then with them. :) |
|
item groups are defined here: the horizontal/vertical comment was about grouping these columns as both horizontal (cloak, cdash) and then both vertical (claw, wings) |
|
Done changes:
Still to do:
Not planned to changed at the moment: Grimmchild
(hope, didn't forget anything) |
…nal show if they are already collected or not.
|
|
Full view of collected icons. (all sections are now also below each other) Full view of not collected icons. Multi tracker (Elevator Pass is now shown as equipped, when it's not in the pool). When Elevator is in pool and not collected the multi tracker shows it properly. Splitted Cloak: Double Left Cloak, no Right Cloak = Left Shade Cloak Splitted Cloak: Right Cloak, no Left Cloak = Right Mothwing Cloak Dreamgate is part of the Dreamnail chain. Vertical and horizontal movement skills besides each other. (multi and player tracker) |
|
why did Progressive Dive get switched to "Quake"? the item group is "Dive" other than that this looks great, thanks |
|
As I searched for Scream I have read somewhere Quake for Dive. Probably here. Overlooked then obviously that it is dive as you've sent the reference. Is now changed back to "Dive". |
Exempt-Medic
removed
the
waiting-on: world-maintainer
|
This seems to be missing the Godtuner |
good point, Godtuner is now required progression for exactly the godhome flowerquest goal so it should be tracked properly |
|
I'm not at home this week. I'll add the stuff either in between if there is some time or next week. |
The godseeker flower quest dialogue that is required for the godhome flower ending won't trigger unless you have godtuner |
|
Godtuner added Multitracker Single tracker |
|
Is it fine so far or should be changed something else? |
|
I was also noticing that the non-multitracker version of the HK Tracker doesn't seem to be refreshing, not sure where that problem is because I wasn't seeing any error/warning on my webhost log |
Co-authored-by: qwint <[email protected]>
|
Template for that was the ALttP tracker. There is just one element with the class .inventory-grid, here we have one per item type. So a change was missing to update all elements. Fixed. |
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
A tracker for Hollow Knight on the AP website.
How was this tested?
Local game hosting and creating different settings with text client item getting.
If this makes graphical changes, please attach screenshots.
Multitracker overview over all available HK games.
In the charms section are rows just created for players who have either randomized charms or charm notches.
If a option is not randomized it will be shown with a dash on a grayish background. (there are some exceptions like eggs because they seem to be send to the AP tracker anyway - in that case that are just a few and not all found in the seed)
Handling of the skills
Handling of the progressive charms.
View on a single player tracker.
The single player tracker just shows icons to options which were randomized. Not randomized stuff will be hidden / not generated for the page tracker.
In the rare case someone chooses just options which are not handled by the tracker (i.e. Geo Rocks or Lore Tablets) there will just be shown a message. There seems not to be a way to avoid the tracker at all in this case therefore a short notification.
