Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: some low-hanging fruit on the strict type check #3416

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Core: some low-hanging fruit on the strict type check #3416

wants to merge 7 commits into from
+25 −10

Conversation

beauxq
Copy link
Collaborator

@beauxq beauxq commented May 29, 2024

What is this fixing or adding?

Just some low-hanging fruit on the task of moving core towards strict type checking.

A few are empty __init__.py files, but it's still good to type check them because code could be added to them in the future.
A few required no changes.
A few required small changes.

bump pyright version

How was this tested?

just what's done in CI

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 29, 2024
@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. is: refactor/cleanup Improvements to code/output readability or organizization. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. labels May 30, 2024
qwint
qwint approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look reasonable, don't fully understand the pyright specific changes, but didn't seem wrong on light googling

purely a code review, did not run any code/tests on my machine

nicholassaylor
nicholassaylor approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally and everything LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@agilbert1412 agilbert1412 agilbert1412 approved these changes

@qwint qwint qwint approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beauxq @qwint @agilbert1412 @nicholassaylor @Exempt-Medic