Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraria: migrate to new options API #3414

Merged
merged 1 commit into from
May 28, 2024
Merged

Terraria: migrate to new options API #3414

merged 1 commit into from
May 28, 2024

Conversation

Seldom-SE
Copy link
Collaborator

What is this fixing or adding?

Switches Terraria to the new options API. See #3284.

How was this tested?

I generated some worlds with different options and checked the spoilers to make sure the options are still being respected. I also played the beginning of a game with the client.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 28, 2024
@Seldom-SE Seldom-SE mentioned this pull request May 28, 2024
Open
65 tasks
@Seldom-SE Seldom-SE added the is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. label May 28, 2024
Silvris
Silvris approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@Silvris Silvris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, but changes look correct.

Exempt-Medic
Exempt-Medic approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, searched for other option getters with a self] and player] search, did 2.5K random generations, didn't find anything missed.

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 28, 2024
@NewSoupVi NewSoupVi merged commit 04e9f5c into ArchipelagoMW:main May 28, 2024
16 checks passed
@Seldom-SE Seldom-SE deleted the ter_options_api branch May 28, 2024 20:11
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@Seldom-SE
Migrate Terraria to new options API (ArchipelagoMW#3414)
71d269b
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@Seldom-SE @sflavelle
Migrate Terraria to new options API (ArchipelagoMW#3414)
124ecd3
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Seldom-SE @qwint
Migrate Terraria to new options API (ArchipelagoMW#3414)
a93fd43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@Silvris Silvris Silvris approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

Assignees
No one assigned
Labels
is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Seldom-SE @NewSoupVi @Silvris @Exempt-Medic