Core: Adding remove items from pool as a generic opt-in option #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Ishigh1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
It just adds the option as an opt-in. Since I don't maintain a core game, no game gets it in this PR, unless you want me to.
I'm not sure if it should throw exception if you try to remove things from the item pool if they aren't in it, but it's the behavior of start_inventory_from_pool
How was this tested?
By removing swords in the item pool of TUNIC. It worked as expected, also throwing exception if I tried to remove too many swords or if the game became unbeatable because of it
If this makes graphical changes, please attach screenshots.